impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add -build shared libs for default build for speed.
Date Tue, 08 Nov 2016 18:52:10 GMT
Jim Apple has posted comments on this change.

Change subject: Add -build_shared_libs for default build for speed.
......................................................................


Patch Set 1:

> I'm ok with this as long as we have automated test coverage of this
 > script (in case the shared libs build breaks) and we stick with
 > using static linking for all automated testing (since that's the
 > configuration of Impala that is deployed).

We do have automated coverage. I would love it if 

I'm sure many people deploy with -release and without -so, but it wouldn't surprise me if
others ship with -so.

-- 
To view, visit http://gerrit.cloudera.org:8080/4970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83db07e59ff339dcce7362bd296ebcfd60b71d6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message