impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add -build shared libs for default build for speed.
Date Tue, 08 Nov 2016 18:51:36 GMT
Dan Hecht has posted comments on this change.

Change subject: Add -build_shared_libs for default build for speed.
......................................................................


Patch Set 1:

> I'm fine with this change, but I remember Dan had some reservations
 > when this change was initially proposed a long time ago. Dan?

My concern was not with this change, but related. It was with a change that flipped to using
shared libs everywhere, and my concern is that we should test something more similar to what
we actually ship. i.e. tests and perf should still use static linking.

For dev bootstrapping, I'm fine with this.

-- 
To view, visit http://gerrit.cloudera.org:8080/4970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83db07e59ff339dcce7362bd296ebcfd60b71d6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message