impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Improve Kudu UPSERT test coverage
Date Tue, 08 Nov 2016 18:46:08 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: Improve Kudu UPSERT test coverage
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4953/2//COMMIT_MSG
Commit Message:

PS2, Line 9: relea
> release
Done


PS2, Line 10: 2.8,
> 2.8
Done


PS2, Line 9: In preparation for the public release of Kudu integration in
           : 2.8, we need to make sure that we've covered as much of the
           : Kudu related functionality with tests as possible.
           : 
> Not really needed in the commit.
Done


http://gerrit.cloudera.org:8080/#/c/4953/1/testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test:

PS1, Line 680: 
             : 
             : 
             : 
> Ah, makes sense. Thanks for looking into that, I think it's fine. We can th
IMPALA-4445


http://gerrit.cloudera.org:8080/#/c/4953/2/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

PS2, Line 356: select * from %s
> might be good to put a limit on here for safety, e.g. the number of rows sp
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e7afbef60186edb00a9d11fbe5a8c64931add6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message