impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles
Date Tue, 08 Nov 2016 18:23:02 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles
......................................................................


Patch Set 1: Code-Review+2

I see.  Since we're going to have this extra layer eventually anyway (when using the builder
as a true sink) and it seems it'll be simpler that way, consider doing that alternative. 
But I don't feel too strongly about it, I'm also okay with this fix in the meantime.

-- 
To view, visit http://gerrit.cloudera.org:8080/4969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db623a84c47d5904033ec26aece74f500a2c9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message