impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.
Date Tue, 08 Nov 2016 09:35:03 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk  overflow.
......................................................................


Patch Set 3:

(5 comments)

Please mark comments as done and post replies here when you're done.

http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/init.cc
File be/src/common/init.cc:

Line 69:              "to retain.The most recent audit event log files are retained. If set
to 0, "
Please follow the indentation of the surrounding code


PS3, Line 69: .T
nit: space missing


http://gerrit.cloudera.org:8080/#/c/4971/1/be/src/common/logging.cc
File be/src/common/logging.cc:

Line 58: const string AUDIT_EVENT_LOG_FILE_PREFIX = "impala_audit_event_log_1.0-";
> Where in the code do we make sure that event log files are always written w
Please address this comment.


http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/logging.cc
File be/src/common/logging.cc:

Line 185:   // e.g. /tmp/impalad.*.INFO.*
This line looks wrong, please update comment.


http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/logging.h
File be/src/common/logging.h:

Line 90: /// and removes
line wrapping


-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message