impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable
Date Tue, 08 Nov 2016 06:04:58 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3552: Make incremental stats max serialized size configurable
......................................................................


Patch Set 7:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

Line 151: Status Catalog::GetCatalogConfigBytes(JNIEnv* jni_env, jbyteArray* cfg_bytes) const
{
Can we refactor the code to only have one GetBackendConfigBytes() or are there any differences
between this one and the one used for the FE?


http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:

Line 106:   Status GetCatalogConfigBytes(JNIEnv* jni_env, jbyteArray* cfg_bytes) const;
GetBackendConfigBytes()?


http://gerrit.cloudera.org:8080/#/c/4867/5/common/thrift/Types.thrift
File common/thrift/Types.thrift:

Line 249:   6: optional bool compute_lineage
> Isn't it better if we let the backend drive the decision here and just pass
Let's continue down this path for now and see how it goes.


-- 
To view, visit http://gerrit.cloudera.org:8080/4867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-Reviewer: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message