impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input
Date Mon, 07 Nov 2016 21:27:03 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
......................................................................


Patch Set 9:

(3 comments)

Thanks for the reviews. I'm running another private job to test the change on S3 and will
update the Jira once it's done.

http://gerrit.cloudera.org:8080/#/c/4863/9/tests/query_test/test_insert_behaviour.py
File tests/query_test/test_insert_behaviour.py:

Line 488:     import os
> why?
Sry, leftover from trying to get the tests to work.


Line 491:     table_location = DEFAULT_FS + "/" + table_path
> I'm confused. Doesn't get_fs_path() do the right thing? Why do we have to a
It does. I couldn't figure out why FILESYSTEM_PREFIX works the way it does on the Jenkins
host I ran this on, but not on my local dev machine. Sailesh helped me, now I'm convinced
it should work. I'm running another private build and will update this change again once I
have results.


Line 550:       table, table_location)
> indent 4
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message