impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats
Date Mon, 07 Nov 2016 20:13:39 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4975/1/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

PS1, Line 1034: 
> I don't quite see the reason for this dcheck. If total_num_values_ becomes 
Makes sense. I chose to drop the input if it looks malformed.


-- 
To view, visit http://gerrit.cloudera.org:8080/4975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33f1e6fb45505dce7d79497d1632c5f63a409151
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message