impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Preview: IMPALA-4363: Add timestamp validation
Date Mon, 07 Nov 2016 20:10:18 GMT
Alex Behm has posted comments on this change.

Change subject: Preview: IMPALA-4363: Add timestamp validation
......................................................................


Patch Set 1:

Overall structure looks good ok to me, minus Lars' comments.

Ideally, we'd have a cheaper way to validate other than doing DebugString() with a try-catch.
It should be possible for us to determine the acceptable integer value range and check that.

-- 
To view, visit http://gerrit.cloudera.org:8080/4968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9988449aa0dc0f39fabb91ce6cce0dd8a06e8bcf
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message