impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats
Date Mon, 07 Nov 2016 19:57:08 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4975/1/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

PS1, Line 1034: DCHECK(total_num_values_ > 0);
I don't quite see the reason for this dcheck. If total_num_values_ becomes < 0, we should
catch that at the point it happens (rather than here). So in SetStats(), I think you should
check for total_num_values_ >= 0, and set it to 0 - or just drop the update completely
- if it's not. (Rather than DCHECK - because here we're dealing with input from an RPC I think,
and it's better to be robust where possible in those situations).


-- 
To view, visit http://gerrit.cloudera.org:8080/4975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33f1e6fb45505dce7d79497d1632c5f63a409151
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message