impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input
Date Mon, 07 Nov 2016 19:23:47 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input

Patch Set 7:

File testdata/workloads/functional-query/queries/QueryTest/insert.test:

Line 912: partition (year, month) /*+ clustered */
> Done. I added a test and a DCHECK in HdfsTableSink::WriteClusteredRowBatch(
We could add warning when inserting into an unpartitioned  table with a clustered hint. Not
in this patch, please.
File tests/query_test/

Line 112:   def test_insert_test(self, vector):
> This makes it possible to test only "insert.test" by specifying "-k test_in
Sorry missed that in the commit msg. Works for me.
File tests/query_test/

Line 534:     insert_stmt = """insert into {0} partition(l_returnflag) /*+ clustered */ select
> No, it doesn't make any assumptions. I added the hint.
I think it does make an assumption. If for whatever reason this plan switched to "noshuffle",
we'd get more files and fail this test.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message