impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners
Date Sat, 05 Nov 2016 04:43:55 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4391: fix dropped statuses in scanners
......................................................................


IMPALA-4391: fix dropped statuses in scanners

As far as I'm aware we haven't seen any failures related to these in
practice, but fixing them as a preventative measure.

Testing:
I was unable to reproduce this easily by adding a failpoint. I suspect
that stress testing of the affected file formats would have eventually
found this, because of the similarity to IMPALA-3962.

Change-Id: I7c47f8b29a20dc74ad9e9e1c58b3d7ed95de4d35
Reviewed-on: http://gerrit.cloudera.org:8080/4938
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/base-sequence-scanner.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-rcfile-scanner.cc
M be/src/exec/hdfs-rcfile-scanner.h
M be/src/exec/hdfs-scanner.h
M be/src/exec/hdfs-sequence-scanner.cc
M be/src/exec/hdfs-text-scanner.cc
7 files changed, 19 insertions(+), 15 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4938
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c47f8b29a20dc74ad9e9e1c58b3d7ed95de4d35
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message