impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required
Date Fri, 04 Nov 2016 20:35:18 GMT
Jim Apple has submitted this change and it was merged.

Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required
......................................................................


IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required

This patch now requires users of the Leopard framework to supply a
DOCKER_IMAGE_NAME. The cloudera/impala image isn't being maintained, and
until Apache Impala (incubating) decides to publish its own image, no
default image name is possible. It is still possible to run the Leopard
framework against a homegrown Docker image that has Apache Impala
(incubating) and PostgreSQL installed: simply build such an image and
export the DOCKER_IMAGE_NAME environment variable before running the
controller.

While here, fix some flake8 non-indent problems.

Testing: short Leopard controller / query generator run.

Change-Id: Ic1cb96cb5c9a894f40e0892f3bdd3f3d0158e887
Reviewed-on: http://gerrit.cloudera.org:8080/4936
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Reviewed-by: Jim Apple <jbapple@cloudera.com>
Reviewed-by: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Tested-by: Jim Apple <jbapple@cloudera.com>
---
M tests/comparison/leopard/controller.py
M tests/comparison/leopard/impala_docker_env.py
2 files changed, 3 insertions(+), 6 deletions(-)

Approvals:
  Taras Bobrovytsky: Looks good to me, approved
  Jim Apple: Looks good to me, but someone else must approve; Verified
  Matthew Jacobs: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/4936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1cb96cb5c9a894f40e0892f3bdd3f3d0158e887
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>

Mime
View raw message