impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution
Date Fri, 04 Nov 2016 19:51:06 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution
......................................................................


Patch Set 8:

(3 comments)

Couple of naming questions, otherwise looks good.

http://gerrit.cloudera.org:8080/#/c/4633/8/be/src/runtime/plan-fragment-executor.cc
File be/src/runtime/plan-fragment-executor.cc:

PS8, Line 42: #include "runtime/mem-tracker.h"
what do you need this for?


http://gerrit.cloudera.org:8080/#/c/4633/8/be/src/runtime/runtime-state.cc
File be/src/runtime/runtime-state.cc:

PS8, Line 137: PlanFragmentThreads
Does it work if you pass an empty string? I think "PlanFragmentThreads" is redundant, given
the suffixes attached to all the counters.


http://gerrit.cloudera.org:8080/#/c/4633/8/be/src/runtime/runtime-state.h
File be/src/runtime/runtime-state.h:

PS8, Line 323: plan_fragment_counters_
how about calling this total_thread_statistics_ or similar?

plan_fragment_counters_ doesn't tell me anything about what it contains.


-- 
To view, visit http://gerrit.cloudera.org:8080/4633
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message