impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/
Date Fri, 04 Nov 2016 19:40:02 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/
......................................................................


IMPALA-4421: Send custom cluster & process failure test results to logs/

Improperly nested quotes in tests/run-custom-cluster-tests.sh caused a
directory named "${RESULTS_DIR}" to be created in the tests directory,
which in turned interfered with run-tests.py.

Additonally noticed that run-process-failure-tests.sh was creating a
results directory within tests/. We shoud not be polluting the tests/
dir with random test artifacts, so changed the result directory path
for those tests as well.

Tested by running both scripts, and ensuring that results wound up in
logs/, and nothing was created in tests/.

Change-Id: I475f61b4ba8a693324bbefed8819d029674b66dd
Reviewed-on: http://gerrit.cloudera.org:8080/4918
Reviewed-by: Jim Apple <jbapple@cloudera.com>
Tested-by: Internal Jenkins
---
M tests/run-custom-cluster-tests.sh
M tests/run-process-failure-tests.sh
2 files changed, 9 insertions(+), 8 deletions(-)

Approvals:
  Jim Apple: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I475f61b4ba8a693324bbefed8819d029674b66dd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>

Mime
View raw message