impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Date Fri, 04 Nov 2016 17:55:44 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4048: Misc. improvements to /sessions
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

Line 466:         "start_time_sort", session.second->last_accessed_ms, document->GetAllocator());
> session.second->start_time_ms?
Oops, thanks.


http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/thirdparty/mustache/mustache.cc
File be/src/thirdparty/mustache/mustache.cc:

Line 281:     (*out) << context->GetInt64();
> GetInt()?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message