impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results
Date Fri, 04 Nov 2016 06:56:49 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4266: Java udf returning string can give incorrect results
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4941/1/testdata/workloads/functional-query/queries/QueryTest/java-udf.test
File testdata/workloads/functional-query/queries/QueryTest/java-udf.test:

Line 299: ====w
extraneous w?


http://gerrit.cloudera.org:8080/#/c/4941/1/tests/test-hive-udfs/src/main/java/org/apache/impala/ReplaceStringUdf.java
File tests/test-hive-udfs/src/main/java/org/apache/impala/ReplaceStringUdf.java:

Line 3: import org.apache.hadoop.hive.ql.exec.UDF;
nit: order of imports


-- 
To view, visit http://gerrit.cloudera.org:8080/4941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I705d271814cb1143f67d8a12f4fd87bab7a8e161
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message