impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock
Date Thu, 03 Nov 2016 21:28:35 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock
......................................................................


IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

This fixes a potential hang because the code took
QueryExecState::lock_ before SessionState::lock, which is
the wrong order. A hang has not yet been observed.

The code that was taking the session lock doesn't actually
need to be holding the QueryExecState lock_, so this is easy
to fix by moving the relevant code.

Testing: Running an exhaustive test job, and stress tests
manually.

Change-Id: I2aa36fce78525a80a6b880e1b668105006bc1425
Reviewed-on: http://gerrit.cloudera.org:8080/4895
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/service/query-exec-state.cc
1 file changed, 16 insertions(+), 9 deletions(-)

Approvals:
  Matthew Jacobs: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2aa36fce78525a80a6b880e1b668105006bc1425
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message