impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required
Date Thu, 03 Nov 2016 19:51:45 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required
......................................................................


Patch Set 2:

(2 comments)

Thanks. See patch set 2.

http://gerrit.cloudera.org:8080/#/c/4936/1/tests/comparison/leopard/controller.py
File tests/comparison/leopard/controller.py:

Line 48: 
> Was this extra line intentional?
Yes. It fixes a flake8 warning. Python style requires two lines between top level functions
and classes in a module.  I adjusted the commit message to be slightly more clear on the flake8
warnings I fixed.


http://gerrit.cloudera.org:8080/#/c/4936/1/tests/comparison/leopard/impala_docker_env.py
File tests/comparison/leopard/impala_docker_env.py:

PS1, Line 106: os.environ['DO
> Why is this different from the indexing above? I'm guessing this fails if t
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1cb96cb5c9a894f40e0892f3bdd3f3d0158e887
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message