impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer
Date Thu, 03 Nov 2016 19:09:06 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer
......................................................................


Patch Set 2: -Code-Review

> > Do you have access to the file to repro'ed this in the wild?  And
 > > given that DCHECKs are compiled out of release builds, how did
 > this
 > > cause a problem in the wild?
 > 
 > In the wild, some `insert into ... select from ...` queries have
 > hit this check when converting CSV to Parquet, but I do not have
 > access to those CSV files. A debug build was used while
 > investigating an unrelated issue, that's how the DCHECK failure was
 > noticed.

Oh, oops, I wasn't noticing this was the writier.  In that case, why are these DCHECKs not
valid?  Why does our code create pages with zero values (other than the last)? Or were we
hitting the non-zero compressed size dcheck (and if so, that also doesn't seem to make sense).

-- 
To view, visit http://gerrit.cloudera.org:8080/4835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52e1b1354e9ea056b49331e75e53759952a81b76
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zoltan Ivanfi <zi@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message