impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default
Date Thu, 03 Nov 2016 12:09:41 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3771: Expose kudu client timeout and set default
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

Line 64:     b.add_master_server_addr(address);
nit: single line?


http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/exec/kudu-util.h
File be/src/exec/kudu-util.h:

Line 40: Status CreateKuduClient(const std::vector<std::string>& master_addrs,
Can you add a comment?


http://gerrit.cloudera.org:8080/#/c/4849/2/fe/src/main/java/org/apache/impala/service/BackendConfig.java
File fe/src/main/java/org/apache/impala/service/BackendConfig.java:

Line 43:   private static int kuduClientTimeoutMs_ = 3 * 60 * 1000;
> I don't think there's a good way to set globals across java and the C++ cod
My thought was that we could set this to something like -1 here and then later check that
it was actually correctly set/overridden by the backend. This way we would only have the constant
stored once. But I think it's fine this way, too.


http://gerrit.cloudera.org:8080/#/c/4849/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:

PS2, Line 148:         parsedReplicas = Integer.parseInt(replication
> This should already be checked and thrown in a nice way by analysis. I thin
Ah, didn't know Analysis catches this. I agree that a Precondition makes most sense here.


-- 
To view, visit http://gerrit.cloudera.org:8080/4849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad95e8e38aad4f76d21bac6879db6c02b3c3e045
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message