impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Date Thu, 03 Nov 2016 06:03:23 GMT
Alex Behm has posted comments on this change.

Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4879/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test:

Line 3: compute stats alltypes
> works for me, i just wanted to make sure we have enough coverage to release
fair point, I don't think it gives us complete confidence, but we do get basic functional
coverage and a guard against regressions


-- 
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message