impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/
Date Thu, 03 Nov 2016 02:32:32 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4918/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-4421: Send custom cluster & process failure test results to logs/
> long line
Done


Line 14: results directory within tests/. We shoud not be polluting the tests/
> long line
Done


Line 19: logs/, and nothing was created in tests/.
> Did you look around to see if anything else was depending on run-process-fa
Good question. It looks like absolutely nothing calls it. The line that once called it was
commented out of run-all-tests.sh in 2013. And the tests it refers to are in a directory in
tests/ called "experiments."


http://gerrit.cloudera.org:8080/#/c/4918/1/tests/run-process-failure-tests.sh
File tests/run-process-failure-tests.sh:

PS1, Line 28: s"
> Is this part just extra noise?
Eh, probably.


Line 29: mkdir -p "${RESULTS_DIR}"
> Can you liberally sprinkle some double quotes around, in case IMPALA_HOME h
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I475f61b4ba8a693324bbefed8819d029674b66dd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message