impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4330: Fix JSON syntax in generate metrics.py
Date Wed, 02 Nov 2016 20:01:58 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4330: Fix JSON syntax in generate_metrics.py
......................................................................


IMPALA-4330: Fix JSON syntax in generate_metrics.py

The hardcoded JSON string in MDL_BASE had a superfluous comma, that
tripped both the simplejson and json parsers. This change removes it so
the string works with both parsers.

Change-Id: I98456df28d48ed22cefcc570e88df78fdf441c23
Reviewed-on: http://gerrit.cloudera.org:8080/4887
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Reviewed-by: Jim Apple <jbapple@cloudera.com>
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Internal Jenkins
---
M common/thrift/generate_metrics.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Michael Brown: Looks good to me, but someone else must approve
  Jim Apple: Looks good to me, approved
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98456df28d48ed22cefcc570e88df78fdf441c23
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>

Mime
View raw message