impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present
Date Wed, 02 Nov 2016 16:48:31 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

Patch Set 3:

File be/src/catalog/

PS3, Line 41: spend on trying to establish connection to HMS the "
            :     "first time on startup
> "wait to establish an initial connection to the HMS"

PS3, Line 75: init_first
> init_first seems redundant, here and everywhere else.
File fe/src/main/java/org/apache/impala/catalog/

Line 67:   protected final MetaStoreClientPool metaStoreClientPool_ = new MetaStoreClientPool(0,
> long line

PS3, Line 103: public void initMetaStoreClientPool(long initFirstClientTimeoutSeconds) {
             :     metaStoreClientPool_.addClients(META_STORE_CLIENT_POOL_SIZE,
             :         initFirstClientTimeoutSeconds);
             :   }
> Why not call this in the c'tor any more? (if timeout is < 0, add no clients
Added an overloaded constructor that takes two parameters: the number of clients and the initialization
File fe/src/main/java/org/apache/impala/catalog/

PS3, Line 163: super
> don't think you need super., do you?
Removed initMetaStoreClientPool()
File fe/src/main/java/org/apache/impala/catalog/

PS3, Line 156: Add 'numClients' to the client pool.
             :    * 'initFirstClientTimeoutSeconds' specifies the time (in seconds) spent
on trying to
             :    * initialize the first MetaStore client before giving up.
             :    */
> it might be clearer to call this, initially, as addClients(1, 120), then ca
File tests/experiments/

PS3, Line 61: metadatra
> metadata

PS3, Line 109: statestored.service.wait_for_live_subscriber
> if this fails, I think the test can leave the HMS not running. That will af
In teardown_class() L48 we always call run_hive_server() to make sure that HMS is running
even if a test case fails.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c70f939429e1d0d20284a1307f3ee1278ae047
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-HasComments: Yes

View raw message