impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()
Date Tue, 01 Nov 2016 23:53:10 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal()
......................................................................


Patch Set 4:

(1 comment)

Augmented the comment. Also explained the relationship to the Coordinator locks.

http://gerrit.cloudera.org:8080/#/c/4896/4/be/src/service/query-exec-state.h
File be/src/service/query-exec-state.h:

Line 215:   /// holding this lock.
> what about this?
Updated. The condition was kind-of trivially true since it's only acquired in a couple of
short functions.


-- 
To view, visit http://gerrit.cloudera.org:8080/4896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I785fea0163a90d0633fb6ed77ec7c6882ab5c110
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message