impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock
Date Tue, 01 Nov 2016 00:40:43 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4895/1/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:

PS1, Line 537: session_->kudu_latest_observed_ts = std::max<uint64_t>(
             :           session_->kudu_latest_observed_ts, latest_kudu_ts);
> It's a good idea, though I don't think this lock is particularly highly con
I just grepped through the codebase and one call in particular seems to be made in many places.
"WithSession()". That function gets the session_ lock.

But if it seems like an over-optimization for now, I'm fine with leaving it as it is.


-- 
To view, visit http://gerrit.cloudera.org:8080/4895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2aa36fce78525a80a6b880e1b668105006bc1425
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message