Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6DBFE200BAF for ; Mon, 31 Oct 2016 23:02:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6C58E160B05; Mon, 31 Oct 2016 22:02:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B4DB3160AED for ; Mon, 31 Oct 2016 23:02:41 +0100 (CET) Received: (qmail 31272 invoked by uid 500); 31 Oct 2016 22:02:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 31256 invoked by uid 99); 31 Oct 2016 22:02:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2016 22:02:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 45DE6180628 for ; Mon, 31 Oct 2016 22:02:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id egWgWZJEslLv for ; Mon, 31 Oct 2016 22:02:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 9684D5F30D for ; Mon, 31 Oct 2016 22:02:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9VM2axS028854; Mon, 31 Oct 2016 22:02:36 GMT Message-Id: <201610312202.u9VM2axS028854@ip-10-146-233-104.ec2.internal> Date: Mon, 31 Oct 2016 22:02:36 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Tim Armstrong Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4408=3A_Omit_null_bytes_for_Kudu_scans_with_no_nullable_slots=2E=0A?= X-Gerrit-Change-Id: I762ad9d5cc4198922ea4b5218c504fde355c49a5 X-Gerrit-ChangeURL: X-Gerrit-Commit: ef2cd97e0e125b891f96cff92defcaeb1a5e8fba In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 31 Oct 2016 22:02:42 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4892/1/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java: PS1, Line 315: d.isKuduScanSlot() > Isn't this implied if it's a Kudu table? We should remove if it is. Done -- To view, visit http://gerrit.cloudera.org:8080/4892 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762ad9d5cc4198922ea4b5218c504fde355c49a5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes