Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201610311559.u9VFxfHw022537@ip-10-146-233-104.ec2.internal>
Date: Mon, 31 Oct 2016 15:59:41 +0000
From: "David Knupp (Code Review)" <gerrit@cloudera.org>
To: Michael Brown <mikeb@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>,
        Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>,
        Taras Bobrovytsky <tbobrovytsky@cloudera.com>,
        Harrison Sheinblatt <hs7@hotmail.com>
Reply-To: dknupp@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4352=3A_test_infra=3A_store_Impala/Kudu_primary_keys_in_object_model=0A?=
In-Reply-To: <gerrit.1477603050000.Ib654b6cd0e8c2a172ffb7330497be4d4a751e6e5@gerrit.cloudera.org>
References: <gerrit.1477603050000.Ib654b6cd0e8c2a172ffb7330497be4d4a751e6e5@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Mon, 31 Oct 2016 15:59:47 -0000

David Knupp has posted comments on this change.

Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4873/1/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

PS1, Line 538: return ()
What am I missing here? This doesn't do what the docstring claims -- it only returns an empty tuple.


http://gerrit.cloudera.org:8080/#/c/4873/1/tests/metadata/test_show_create_table.py
File tests/metadata/test_show_create_table.py:

PS1, Line 241: TestInfraCompat
I have wondered whether we should create a new directory under ${IMPALA_HOME}/tests called "infra", as a place to keep (an hopefully add) tests of the infrastructure itself. What do you think of that idea?


-- 
To view, visit http://gerrit.cloudera.org:8080/4873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib654b6cd0e8c2a172ffb7330497be4d4a751e6e5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Harrison Sheinblatt <hs7@hotmail.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes