Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 26978200BB8 for ; Sat, 29 Oct 2016 01:32:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2552D160AF5; Fri, 28 Oct 2016 23:32:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6A2C9160AE4 for ; Sat, 29 Oct 2016 01:32:18 +0200 (CEST) Received: (qmail 48613 invoked by uid 500); 28 Oct 2016 23:32:17 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 48602 invoked by uid 99); 28 Oct 2016 23:32:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Oct 2016 23:32:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 032FEC1A55 for ; Fri, 28 Oct 2016 23:32:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VdfA75epUkcp for ; Fri, 28 Oct 2016 23:32:15 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 12C535F24F for ; Fri, 28 Oct 2016 23:32:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9SNWED0028459; Fri, 28 Oct 2016 23:32:14 GMT Message-Id: <201610282332.u9SNWED0028459@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Oct 2016 23:32:14 +0000 From: "Tim Armstrong (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4223=3A_Handle_truncated_file_read_from_HDFS_cache=0A?= X-Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a X-Gerrit-ChangeURL: X-Gerrit-Commit: 421de6bd56eecef9255b7e7af1b3067e5affcfb3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 28 Oct 2016 23:32:19 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4223: Handle truncated file read from HDFS cache ...................................................................... Patch Set 1: Code-Review+1 Change looks good to me, I'm not convinced this was the problem we hit in IMPALA-4223 though, because it would not have made it this far when there was an error seeking in Open(). I think there's some protection against opening the wrong version of a HDFS file because the mtime of the cached file is checked (this check is definitely a good idea though) -- To view, visit http://gerrit.cloudera.org:8080/4828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No