Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D74E3200BAE for ; Fri, 28 Oct 2016 23:23:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D6019160AE4; Fri, 28 Oct 2016 21:23:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 286FB160ACA for ; Fri, 28 Oct 2016 23:23:45 +0200 (CEST) Received: (qmail 46221 invoked by uid 500); 28 Oct 2016 21:23:44 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 46206 invoked by uid 99); 28 Oct 2016 21:23:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Oct 2016 21:23:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AE9231A79DE for ; Fri, 28 Oct 2016 21:23:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id amQCA7-8Ng43 for ; Fri, 28 Oct 2016 21:23:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1147A5F54E for ; Fri, 28 Oct 2016 21:23:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9SLNY58022235; Fri, 28 Oct 2016 21:23:34 GMT Message-Id: <201610282123.u9SLNY58022235@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Oct 2016 21:23:34 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Jim Apple Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3200_=28buffer_pool=29=3A_warn_if_Status_is_ignored=0A?= X-Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc X-Gerrit-ChangeURL: X-Gerrit-Commit: 8fb0530b3e44999f2641f51132255c315d81e2f3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 28 Oct 2016 21:23:46 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200 (buffer pool): warn if Status is ignored ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/2/be/src/bufferpool/buffer-allocator.h File be/src/bufferpool/buffer-allocator.h: PS2, Line 38: MUST_USE(Status) > Good point! The type attribute would definitely make it easier to apply, I'm ok with holding off until we're in a position to do this, or only using it on key APIs. It doesn't look like GCC supports it as a type attribute until the unreleased version 7. -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes