Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C2B8D200BAE for ; Fri, 28 Oct 2016 17:42:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C1504160AE4; Fri, 28 Oct 2016 15:42:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 12D3E160ACA for ; Fri, 28 Oct 2016 17:42:56 +0200 (CEST) Received: (qmail 4156 invoked by uid 500); 28 Oct 2016 15:42:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 4145 invoked by uid 99); 28 Oct 2016 15:42:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Oct 2016 15:42:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7D417C13A4 for ; Fri, 28 Oct 2016 15:42:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id rYQwaMmDlGMC for ; Fri, 28 Oct 2016 15:42:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4455F5FC2B for ; Fri, 28 Oct 2016 15:42:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9SFgnY4012813; Fri, 28 Oct 2016 15:42:49 GMT Message-Id: <201610281542.u9SFgnY4012813@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Oct 2016 15:42:49 +0000 From: "anujphadke (Code Review)" To: anujphadke , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Tim Armstrong Reply-To: aphadke@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3342=3A_Add_thread_counters_to_monitor_plan_fragment_execution=0A?= X-Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9f20d04b41a21757af4482ba328cf1361ac248fd In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 28 Oct 2016 15:42:57 -0000 anujphadke has uploaded a new patch set (#7). Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution ...................................................................... IMPALA-3342: Add thread counters to monitor plan fragment execution This change removes the use of total_cpu_timer which incorrectly monitors the CPU time. Adding THREAD_COUNTERS to measure the user and sys time in plan fragment execution. This also accounts for the time spent in the hdfs/kudu scanner and in a blocking join. Snippet of a query plan with the newly added PlanFragment THREAD_COUNTERS: Fragment F00: Instance 22405f2d916ba9e6:41f8692c00000009 ..... - PerHostPeakMemUsage: 978.06 MB (1025568440) - PlanFragmentThreadInvoluntaryContextSwitches: 12.85K (12846) - PlanFragmentThreadTotalWallClockTime: 5m25s - PlanFragmentThreadSysTime: 147.673ms - PlanFragmentThreadUserTime: 20s710ms - PlanFragmentThreadVoluntaryContextSwitches: 13.43K (13427) Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 --- M be/src/exec/blocking-join-node.cc M be/src/exec/hdfs-scan-node.cc M be/src/exec/kudu-scan-node.cc M be/src/runtime/plan-fragment-executor.cc M be/src/runtime/plan-fragment-executor.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h 7 files changed, 19 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/4633/7 -- To view, visit http://gerrit.cloudera.org:8080/4633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: anujphadke