Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5D614200BBE for ; Fri, 28 Oct 2016 06:10:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5C099160B01; Fri, 28 Oct 2016 04:10:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A0ECF160AF6 for ; Fri, 28 Oct 2016 06:10:42 +0200 (CEST) Received: (qmail 51064 invoked by uid 500); 28 Oct 2016 04:10:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 51053 invoked by uid 99); 28 Oct 2016 04:10:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Oct 2016 04:10:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EE9A6C0E29 for ; Fri, 28 Oct 2016 04:10:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wkFgDnK8SeTA for ; Fri, 28 Oct 2016 04:10:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EAD7F5FC08 for ; Fri, 28 Oct 2016 04:10:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9S49tMu006006; Fri, 28 Oct 2016 04:09:55 GMT Message-Id: <201610280409.u9S49tMu006006@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Oct 2016 04:09:55 +0000 From: "Alex Behm (Code Review)" To: Dimitris Tsirogiannis , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3724=3A_Support_Kudu_non-covering_range_partitions=0A?= X-Gerrit-Change-Id: I6799c01a37003f0f4c068d911a13e3f060110a06 X-Gerrit-ChangeURL: X-Gerrit-Commit: ae1f763df2b7e422f38c0cb7ebdefedd197b9496 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 28 Oct 2016 04:10:43 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4856/2/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: Line 355: 2: optional ExternalDataSource.TComparisonOp lower_bound_op > But this is where TComparisonOp leaves (which I agree is weird). We need to Just to clarify: TComparisonOp lives in ExternalDataSource because we only need it for pushing predicates to external data sources. The regular built-in exprs don't need a TComparisonOp because we resolve the appropriate BE symbol in FE analysis, so the comparison op is baked into that symbol. Line 355: 2: optional ExternalDataSource.TComparisonOp lower_bound_op > I take it back. Given the way it's been used in the catalog, one boolean ma Let's do whatever feels cleanest. Lmk if you disagree with bool and we can still consider alternatives. -- To view, visit http://gerrit.cloudera.org:8080/4856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6799c01a37003f0f4c068d911a13e3f060110a06 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes