Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 17692200BAA for ; Thu, 27 Oct 2016 20:29:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 15DF7160AF6; Thu, 27 Oct 2016 18:29:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5E1D3160AE6 for ; Thu, 27 Oct 2016 20:29:30 +0200 (CEST) Received: (qmail 82682 invoked by uid 500); 27 Oct 2016 18:29:29 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 82669 invoked by uid 99); 27 Oct 2016 18:29:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 18:29:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 148F1C14F1 for ; Thu, 27 Oct 2016 18:29:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id q6fQsf1SItXD for ; Thu, 27 Oct 2016 18:29:25 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BD22D5F484 for ; Thu, 27 Oct 2016 18:29:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9RISxRY019420; Thu, 27 Oct 2016 18:28:59 GMT Message-Id: <201610271828.u9RISxRY019420@ip-10-146-233-104.ec2.internal> Date: Thu, 27 Oct 2016 18:28:59 +0000 From: "Yonghyun Hwang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Alex Behm , Bharath Vissapragada , Huaisi Xu Reply-To: yonghyun@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3552=3A_make_incremental_stats_max_serialized_size_configurable=0A?= X-Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 X-Gerrit-ChangeURL: X-Gerrit-Commit: 02cad9ae2e2306f9d0ac601cfd9935ff29fec2b4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 27 Oct 2016 18:29:31 -0000 Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable ...................................................................... Patch Set 1: I still have two questions on the fix. 1. currently, tbackendconfig is introduced in types.thrift. is there a better place? (i.e., create a new file solely for this?) 2. tbackendconfig is passed in Catalog::Catalog and ExecEnv::ExecEnv. is it a good place? Please let me have feedbacks on those two. -- To view, visit http://gerrit.cloudera.org:8080/4867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yonghyun Hwang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Huaisi Xu Gerrit-Reviewer: Yonghyun Hwang Gerrit-HasComments: No