Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 09EFA200BB7 for ; Wed, 26 Oct 2016 00:24:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 088E6160AFA; Tue, 25 Oct 2016 22:24:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4F564160AD8 for ; Wed, 26 Oct 2016 00:24:09 +0200 (CEST) Received: (qmail 70700 invoked by uid 500); 25 Oct 2016 22:24:08 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 70689 invoked by uid 99); 25 Oct 2016 22:24:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Oct 2016 22:24:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DD9191A8BF4 for ; Tue, 25 Oct 2016 22:24:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 1H1uzf3tZmLQ for ; Tue, 25 Oct 2016 22:24:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D7C6D5FC6A for ; Tue, 25 Oct 2016 22:24:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9PMM3a8002856; Tue, 25 Oct 2016 22:22:03 GMT Message-Id: <201610252222.u9PMM3a8002856@ip-10-146-233-104.ec2.internal> Date: Tue, 25 Oct 2016 22:22:03 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Henry Robinson Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1169=3A_Admission_control_info_on_the_queries_debug_webpage=0A?= X-Gerrit-Change-Id: I504e3c829a14318721e3a42de6281bcc578f7283 X-Gerrit-ChangeURL: X-Gerrit-Commit: c485189ef357c52a08e37dd3fcbb5b82971811ff In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 25 Oct 2016 22:24:10 -0000 Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/4756/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS5, Line 801: o handle i > I had suggested moving it to be closer to the register call if this is call Done http://gerrit.cloudera.org:8080/#/c/4756/5/be/src/service/query-exec-state.h File be/src/service/query-exec-state.h: Line 157: > Blank line before this. Done Line 159: /// been created and had the pool set yet, or this StmtType doesn't go through admission > missing / Done PS5, Line 161: ol() > nullptr Done -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504e3c829a14318721e3a42de6281bcc578f7283 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes