Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9B834200BA8 for ; Mon, 24 Oct 2016 15:50:42 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9A027160AEB; Mon, 24 Oct 2016 13:50:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E000D160AE1 for ; Mon, 24 Oct 2016 15:50:41 +0200 (CEST) Received: (qmail 45641 invoked by uid 500); 24 Oct 2016 13:50:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 45630 invoked by uid 99); 24 Oct 2016 13:50:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Oct 2016 13:50:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7750E180A5A for ; Mon, 24 Oct 2016 13:50:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3zLOzFRH9os4 for ; Mon, 24 Oct 2016 13:50:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D5F055FC3D for ; Mon, 24 Oct 2016 13:50:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9ODoOrj023190; Mon, 24 Oct 2016 13:50:24 GMT Message-Id: <201610241350.u9ODoOrj023190@ip-10-146-233-104.ec2.internal> Date: Mon, 24 Oct 2016 13:50:24 +0000 From: "Jim Apple (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong Reply-To: jbapple@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4300=3A_Speed_up_BloomFilter=3A=3AOr_with_SIMD=0A?= X-Gerrit-Change-Id: I840799d9cfb81285c796e2abfe2029bb869b0f67 X-Gerrit-ChangeURL: X-Gerrit-Commit: f6b4c78cb8dfe7c8359bda0b23b6875e0ae4f4e2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 24 Oct 2016 13:50:42 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Carry Tim's +2 http://gerrit.cloudera.org:8080/#/c/4813/3//COMMIT_MSG Commit Message: Line 11: up to 184x. > Can you fix this too? Maybe just say "The previous code was not written in Done -- To view, visit http://gerrit.cloudera.org:8080/4813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I840799d9cfb81285c796e2abfe2029bb869b0f67 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes