Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2218200BA7 for ; Fri, 21 Oct 2016 23:25:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D07AA160AE8; Fri, 21 Oct 2016 21:25:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 22B20160ADE for ; Fri, 21 Oct 2016 23:25:37 +0200 (CEST) Received: (qmail 77343 invoked by uid 500); 21 Oct 2016 21:25:37 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 77325 invoked by uid 99); 21 Oct 2016 21:25:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Oct 2016 21:25:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9BA6EC1D05 for ; Fri, 21 Oct 2016 21:25:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 0TyOjgOaE6_1 for ; Fri, 21 Oct 2016 21:25:35 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D2F8F5F1F5 for ; Fri, 21 Oct 2016 21:25:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9LLPYT8015559; Fri, 21 Oct 2016 21:25:34 GMT Message-Id: <201610212125.u9LLPYT8015559@ip-10-146-233-104.ec2.internal> Date: Fri, 21 Oct 2016 21:25:34 +0000 From: "Henry Robinson (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4241=3A_remove_spurious_child_queries_event=0A?= X-Gerrit-Change-Id: I3881d032622750444d750f161ad6843bdbd16c30 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0ea869fcca1208ea745dcccc345a59f48f08e50b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 21 Oct 2016 21:25:39 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-4241: remove spurious child queries event ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4768/1/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: PS1, Line 623: child_queries > We would need to add more state to QueryExecState that is redundant with Ch Oh, right, of course child_queries doesn't get populated until WaitForAll(). Thanks. -- To view, visit http://gerrit.cloudera.org:8080/4768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3881d032622750444d750f161ad6843bdbd16c30 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes