Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1FF5D200BA7 for ; Fri, 21 Oct 2016 23:21:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1E67B160AE8; Fri, 21 Oct 2016 21:21:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 63E7A160ADE for ; Fri, 21 Oct 2016 23:21:57 +0200 (CEST) Received: (qmail 69836 invoked by uid 500); 21 Oct 2016 21:21:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 69824 invoked by uid 99); 21 Oct 2016 21:21:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Oct 2016 21:21:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F038AC12B8 for ; Fri, 21 Oct 2016 21:21:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1OwsT4P4B6Zo for ; Fri, 21 Oct 2016 21:21:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B05F95F1C2 for ; Fri, 21 Oct 2016 21:21:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9LLLqnK015163; Fri, 21 Oct 2016 21:21:52 GMT Message-Id: <201610212121.u9LLLqnK015163@ip-10-146-233-104.ec2.internal> Date: Fri, 21 Oct 2016 21:21:52 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4241=3A_remove_spurious_child_queries_event=0A?= X-Gerrit-Change-Id: I3881d032622750444d750f161ad6843bdbd16c30 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0ea869fcca1208ea745dcccc345a59f48f08e50b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 21 Oct 2016 21:21:58 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4241: remove spurious child queries event ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4768/1/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: PS1, Line 623: child_queries > remind me why we don't put line 616->622 in this kind of conditional? ISTR We would need to add more state to QueryExecState that is redundant with ChildQueryExecutor's state (since ChildQueryExecutor obviously knows whether any child queries were running). Normally this wouldn't be too bad but currently the locking rules around QueryExecState's members are so confusing I think we should avoid adding state unless it's necessary. -- To view, visit http://gerrit.cloudera.org:8080/4768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3881d032622750444d750f161ad6843bdbd16c30 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes