Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0253F200BB1 for ; Thu, 20 Oct 2016 08:23:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 00DB5160AFB; Thu, 20 Oct 2016 06:23:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 49676160AEA for ; Thu, 20 Oct 2016 08:23:08 +0200 (CEST) Received: (qmail 27663 invoked by uid 500); 20 Oct 2016 06:23:07 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 27648 invoked by uid 99); 20 Oct 2016 06:23:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 06:23:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 12E3EC0A88 for ; Thu, 20 Oct 2016 06:23:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id BLhMQzcxCEY1 for ; Thu, 20 Oct 2016 06:23:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7A23F5FC9E for ; Thu, 20 Oct 2016 06:23:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9K6Hgs4007026; Thu, 20 Oct 2016 06:17:42 GMT Message-Id: <201610200617.u9K6Hgs4007026@ip-10-146-233-104.ec2.internal> Date: Thu, 20 Oct 2016 06:17:42 +0000 From: "Yuanhao Luo (Code Review)" To: Yuanhao Luo , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: luoyuanhao@software.ict.ac.cn X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4325=3A_StmtRewrite_lost_parentheses_of_CompoundPredicate=0A?= X-Gerrit-Change-Id: I79bfc67605206e0e026293bf7032a88227a95623 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0d4699eb58fc96e3572b2ce0870f2c65db38c68a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 20 Oct 2016 06:23:09 -0000 Yuanhao Luo has uploaded a new patch set (#3). Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate ...................................................................... IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate StmtRewrite lost parentheses of CompoundPredicate in pushNegationToOperands() and leads to incorrect toSql() result. Even though this issue would not leads to incorrect result of query, it makes user confuse of the logical operator precedence of predicates shown in EXPLAIN statement. Change-Id: I79bfc67605206e0e026293bf7032a88227a95623 --- M fe/src/main/java/org/apache/impala/analysis/Expr.java M testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test 2 files changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/4753/3 -- To view, visit http://gerrit.cloudera.org:8080/4753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79bfc67605206e0e026293bf7032a88227a95623 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yuanhao Luo Gerrit-Reviewer: Alex Behm