Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7311B200BB1 for ; Thu, 20 Oct 2016 00:30:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 71C88160AFB; Wed, 19 Oct 2016 22:30:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B86F2160AEA for ; Thu, 20 Oct 2016 00:30:36 +0200 (CEST) Received: (qmail 6544 invoked by uid 500); 19 Oct 2016 22:30:35 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6533 invoked by uid 99); 19 Oct 2016 22:30:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Oct 2016 22:30:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0C5C61A04AA for ; Wed, 19 Oct 2016 22:30:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MW1NqM1zPFDd for ; Wed, 19 Oct 2016 22:30:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B015D5FAFA for ; Wed, 19 Oct 2016 22:30:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9JMUMmf026359; Wed, 19 Oct 2016 22:30:22 GMT Message-Id: <201610192230.u9JMUMmf026359@ip-10-146-233-104.ec2.internal> Date: Wed, 19 Oct 2016 22:30:22 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4269=3A_Codegen_merging_exchange_node=0A?= X-Gerrit-Change-Id: I944b8d52ea63ede58e4dc6fbe6e6953756394d41 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1ace4df08a616d52123cdbc60aa0a54f5ef7aedd In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 19 Oct 2016 22:30:37 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4269: Codegen merging exchange node ...................................................................... Patch Set 1: Code-Review+2 Change is a straightforward application of an existing pattern and I'm confident we have a good amount of coverage for the sort. -- To view, visit http://gerrit.cloudera.org:8080/4759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I944b8d52ea63ede58e4dc6fbe6e6953756394d41 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No