Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C6B85200BB1 for ; Thu, 20 Oct 2016 00:03:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C55D5160AFB; Wed, 19 Oct 2016 22:03:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 16336160AEA for ; Thu, 20 Oct 2016 00:03:36 +0200 (CEST) Received: (qmail 53701 invoked by uid 500); 19 Oct 2016 22:03:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53674 invoked by uid 99); 19 Oct 2016 22:03:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Oct 2016 22:03:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7CB811A04CE for ; Wed, 19 Oct 2016 22:03:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Dav8gekiiBn0 for ; Wed, 19 Oct 2016 22:03:33 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8572560DD4 for ; Wed, 19 Oct 2016 22:03:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9JM3Xn5024359; Wed, 19 Oct 2016 22:03:33 GMT Message-Id: <201610192203.u9JM3Xn5024359@ip-10-146-233-104.ec2.internal> Date: Wed, 19 Oct 2016 22:03:33 +0000 From: "Alex Behm (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Todd Lipcon Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4134=2CIMPALA-3704=3A_Kudu_INSERT_improvements=0A?= X-Gerrit-Change-Id: I5542b9a061b01c543a139e8722560b1365f06595 X-Gerrit-ChangeURL: X-Gerrit-Commit: 797cd71e0944b50e39f07425eba3427207ee829b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 19 Oct 2016 22:03:38 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: Line 132: KUDU_RETURN_IF_ERROR(s, "Unable to set flush mode"); // Return error status for RELEASE We have the same error weirdness for the other session_->Set*() calls. I'm ok with leaving KUDU_RETURN_IF_ERROR() with a brief comment. -- To view, visit http://gerrit.cloudera.org:8080/4728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5542b9a061b01c543a139e8722560b1365f06595 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes