Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D1CCB200BB3 for ; Wed, 19 Oct 2016 08:23:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D024F160AF7; Wed, 19 Oct 2016 06:23:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 247B9160AE5 for ; Wed, 19 Oct 2016 08:23:56 +0200 (CEST) Received: (qmail 75987 invoked by uid 500); 19 Oct 2016 06:23:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 75975 invoked by uid 99); 19 Oct 2016 06:23:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Oct 2016 06:23:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 68E98C0A88 for ; Wed, 19 Oct 2016 06:23:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id UqajpJpNp67f for ; Wed, 19 Oct 2016 06:23:52 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2A0305F56D for ; Wed, 19 Oct 2016 06:23:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9J6NPTu007323; Wed, 19 Oct 2016 06:23:25 GMT Message-Id: <201610190623.u9J6NPTu007323@ip-10-146-233-104.ec2.internal> Date: Wed, 19 Oct 2016 06:23:25 +0000 From: "Marcel Kornacker (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2521=3A_Add_clustered_hint_to_insert_statements=0A?= X-Gerrit-Change-Id: I412153bd8435d792bd61dea268d7a3b884048f14 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8150cd7e27afafc2b90823809448085747494155 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 19 Oct 2016 06:23:58 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4745/1/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: Line 275: public PlanFragment addClusteringFragment(PlanFragment inputFragment, > Done i don't think of the logic as orthogonal, because it modifies the insert process. also, i don't see how this is relevant for single-node plans - if you're inserting a lot of data with num_nodes = 1, there's something wrong. you can restructure createInsertFragment to use to two helper functions, for distribution and clustering. -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412153bd8435d792bd61dea268d7a3b884048f14 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes