Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BDC2F200BAA for ; Thu, 13 Oct 2016 06:31:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BC5C8160AEE; Thu, 13 Oct 2016 04:31:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0DE36160ACA for ; Thu, 13 Oct 2016 06:31:48 +0200 (CEST) Received: (qmail 84730 invoked by uid 500); 13 Oct 2016 04:31:47 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 84711 invoked by uid 99); 13 Oct 2016 04:31:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Oct 2016 04:31:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 93FA8180842 for ; Thu, 13 Oct 2016 04:31:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id FqetVq7HoBjk for ; Thu, 13 Oct 2016 04:31:44 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B90DE5FB38 for ; Thu, 13 Oct 2016 04:31:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9D4VgCY003367; Thu, 13 Oct 2016 04:31:42 GMT Message-Id: <201610130431.u9D4VgCY003367@ip-10-146-233-104.ec2.internal> Date: Thu, 13 Oct 2016 04:31:42 +0000 From: "Internal Jenkins (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4289=3A_Mark_agg_slots_of_NDV=28=29_functions_as_non-nullable=2E=0A?= X-Gerrit-Change-Id: I1c05b8dfb797b2a42ee1a7bf14ad56bb83d2b1c5 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0b3efb19cc0d971a47d0b7d7928a2d311c13e65a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 13 Oct 2016 04:31:49 -0000 Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4289: Mark agg slots of NDV() functions as non-nullable. ...................................................................... IMPALA-4289: Mark agg slots of NDV() functions as non-nullable. This change might give a minor speedup to COMPUTE STATS and COMPUTE INCREMENTAL STATS. In any case, marking the slots non-nullable seems strictly better than leaving them nullable. Testing: I ran our local testdata/compute-table-stats.sh and it succeeded. Change-Id: I1c05b8dfb797b2a42ee1a7bf14ad56bb83d2b1c5 Reviewed-on: http://gerrit.cloudera.org:8080/4707 Reviewed-by: Tim Armstrong Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M fe/src/main/java/org/apache/impala/analysis/AggregateInfoBase.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved Tim Armstrong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/4707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c05b8dfb797b2a42ee1a7bf14ad56bb83d2b1c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong