Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3792B200B9B for ; Wed, 12 Oct 2016 11:23:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1A272160AD4; Wed, 12 Oct 2016 09:23:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6C5FB160AD3 for ; Wed, 12 Oct 2016 11:23:03 +0200 (CEST) Received: (qmail 54414 invoked by uid 500); 12 Oct 2016 09:23:02 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 54394 invoked by uid 99); 12 Oct 2016 09:23:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Oct 2016 09:23:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7EA5718009B for ; Wed, 12 Oct 2016 09:23:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Pb1n-1yCy25m for ; Wed, 12 Oct 2016 09:22:59 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 07DCF5F22E for ; Wed, 12 Oct 2016 09:22:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9C9Mwar014568; Wed, 12 Oct 2016 09:22:58 GMT Message-Id: <201610120922.u9C9Mwar014568@ip-10-146-233-104.ec2.internal> Date: Wed, 12 Oct 2016 09:22:58 +0000 From: "Internal Jenkins (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3943=3A_Do_not_throw_scan_errors_for_empty_Parquet_files=2E=0A?= X-Gerrit-Change-Id: I50ac3df6ff24bc5c384ef22e0f804a5132adb62e X-Gerrit-ChangeURL: X-Gerrit-Commit: 0449b5beaba89b02e8bc7fe133b4dc5fbe33fe81 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 12 Oct 2016 09:23:04 -0000 Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3943: Do not throw scan errors for empty Parquet files. ...................................................................... IMPALA-3943: Do not throw scan errors for empty Parquet files. For Parquet files with no row groups but with num_rows=0 in the file footer the Parquet scanner returns an error indicating that the file is invalid. This behavior is a regression from previous Impala versions which used to accept such files. This patch restores the previous behavior and adds tests. Change-Id: I50ac3df6ff24bc5c384ef22e0f804a5132adb62e Reviewed-on: http://gerrit.cloudera.org:8080/4693 Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M be/src/exec/hdfs-parquet-scanner.cc M testdata/data/README A testdata/data/zero_rows_one_row_group.parquet A testdata/data/zero_rows_zero_row_groups.parquet A testdata/workloads/functional-query/queries/QueryTest/parquet-zero-rows.test M tests/query_test/test_scanners.py 6 files changed, 65 insertions(+), 1 deletion(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50ac3df6ff24bc5c384ef22e0f804a5132adb62e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker