Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4295A200B9F for ; Tue, 11 Oct 2016 21:59:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 41370160AE6; Tue, 11 Oct 2016 19:59:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 887DF160AC3 for ; Tue, 11 Oct 2016 21:59:37 +0200 (CEST) Received: (qmail 9181 invoked by uid 500); 11 Oct 2016 19:59:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 9160 invoked by uid 99); 11 Oct 2016 19:59:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Oct 2016 19:59:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E113518059B for ; Tue, 11 Oct 2016 19:59:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WB5SFsje0Tg6 for ; Tue, 11 Oct 2016 19:59:34 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5D4025FAF7 for ; Tue, 11 Oct 2016 19:59:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u9BJxRZc000851; Tue, 11 Oct 2016 19:59:27 GMT Message-Id: <201610111959.u9BJxRZc000851@ip-10-146-233-104.ec2.internal> Date: Tue, 11 Oct 2016 19:59:27 +0000 From: "Alex Behm (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3348=3A_Avoid_per-slot_check_vector_size_in_KuduScanner=0A?= X-Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58 X-Gerrit-ChangeURL: X-Gerrit-Commit: 517070741adb480dfa6da119d3b5a1809f5bfca7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 11 Oct 2016 19:59:38 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4688/1/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 241: for (int i = 0; i < num_string_slots_; ++i) { Wouldn't storing the size here have the same effect, i.e.: Seems simpler. int num_string_slots = string_slots_.size(); for (int i = 0; i < num_string_slots; ++i) { ... -- To view, visit http://gerrit.cloudera.org:8080/4688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Alex Behm Gerrit-HasComments: Yes