Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1F30D200B9A for ; Fri, 7 Oct 2016 19:49:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1DE93160AE8; Fri, 7 Oct 2016 17:49:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5D542160AC6 for ; Fri, 7 Oct 2016 19:49:47 +0200 (CEST) Received: (qmail 353 invoked by uid 500); 7 Oct 2016 17:49:46 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 337 invoked by uid 99); 7 Oct 2016 17:49:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Oct 2016 17:49:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 19F451A00F0 for ; Fri, 7 Oct 2016 17:49:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id JpOn54ETuPEI for ; Fri, 7 Oct 2016 17:49:43 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 778D65F233 for ; Fri, 7 Oct 2016 17:49:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u97HnfCo006141; Fri, 7 Oct 2016 17:49:41 GMT Message-Id: <201610071749.u97HnfCo006141@ip-10-146-233-104.ec2.internal> Date: Fri, 7 Oct 2016 17:49:41 +0000 From: "Bharath Vissapragada (Code Review)" To: Huaisi Xu , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Alex Behm , Tim Armstrong Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1702=3A_Enforce_table_level_consistency=0A?= X-Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2 X-Gerrit-ChangeURL: X-Gerrit-Commit: c0450c371f4c18b02a24f1ac2e35bd8a2d23979f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 07 Oct 2016 17:49:48 -0000 Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency ...................................................................... Patch Set 11: Code-Review+1 (1 comment) The change looks fine to me. Thanks for working on this Huaisi. http://gerrit.cloudera.org:8080/#/c/4349/11/fe/src/main/java/org/apache/impala/catalog/View.java File fe/src/main/java/org/apache/impala/catalog/View.java: PS11, Line 92: testig not your change, but please fix the typo. -- To view, visit http://gerrit.cloudera.org:8080/4349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Huaisi Xu Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes