Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7EF32200B99 for ; Wed, 5 Oct 2016 22:00:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7D799160ADE; Wed, 5 Oct 2016 20:00:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C2338160AC9 for ; Wed, 5 Oct 2016 22:00:56 +0200 (CEST) Received: (qmail 95024 invoked by uid 500); 5 Oct 2016 20:00:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 95009 invoked by uid 99); 5 Oct 2016 20:00:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2016 20:00:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 37F771A5488 for ; Wed, 5 Oct 2016 20:00:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id nIvyY_ZKeq2I for ; Wed, 5 Oct 2016 20:00:53 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 9B81D5F54E for ; Wed, 5 Oct 2016 20:00:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u95K0pfZ021400; Wed, 5 Oct 2016 20:00:51 GMT Message-Id: <201610052000.u95K0pfZ021400@ip-10-146-233-104.ec2.internal> Date: Wed, 5 Oct 2016 20:00:51 +0000 From: "Yonghyun Hwang (Code Review)" To: anujphadke , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3342=3A_Adding_new_timer_to_accurately_measure_the_TotalCpuTime=0A?= X-Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 X-Gerrit-ChangeURL: X-Gerrit-Commit: f08771b4ab4dee1e98efd4cda39c66dc268e2e07 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 05 Oct 2016 20:00:57 -0000 Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3342: Adding new timer to accurately measure the TotalCpuTime ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4633/1/be/src/util/stopwatch.h File be/src/util/stopwatch.h: PS1, Line 237: int64_t utime_diff = (end.ru_stime.tv_sec - start_.ru_stime.tv_sec) * 1000L * 1000L * 1000L : + (end.ru_stime.tv_usec - start_.ru_stime.tv_usec); just 2 simple questions. 1. are we considering "system CPU time" only (excluding "user CPU time")? 2. by any chance, (someone resets resource usage?) can utime_diff be negative? -- To view, visit http://gerrit.cloudera.org:8080/4633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Yonghyun Hwang Gerrit-HasComments: Yes