Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201610032013.u93KDxZQ003246@ip-10-146-233-104.ec2.internal>
Date: Mon, 3 Oct 2016 20:13:59 +0000
From: "Bharath Vissapragada (Code Review)" <gerrit@cloudera.org>
To: Huaisi Xu <hxu@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>,
        Alex Behm <alex.behm@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>
Reply-To: bharathv@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1702=3A_Enforce_table_level_consistency_accross_service=0A?=
In-Reply-To: <gerrit.1473443647000.Ifad648b72684ae495ec387590ab1bc58ce5b39e2@gerrit.cloudera.org>
References: <gerrit.1473443647000.Ifad648b72684ae495ec387590ab1bc58ce5b39e2@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Mon, 03 Oct 2016 20:14:08 -0000

Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-1702: Enforce table level consistency accross service
......................................................................


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4349/3//COMMIT_MSG
Commit Message:

PS3, Line 12: If backend sees these,
            : it will overwrites each other in an 1:1 table ID to table
            : descriptor map.
might need a little rephrase.


PS3, Line 18: activities
operations?


PS3, Line 22:  
..issue.. (same in next statement too.)


http://gerrit.cloudera.org:8080/#/c/4349/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

PS3, Line 296: HashMap
I think its better to use the parent Map<> class here (that seems to be consistent usage elsewhere in the code).


PS3, Line 2282: Returns the Catalog Table object for the given database and table name.
              :    * Adds the table to this analyzer's "missingTbls_" and throws an AnalysisException if
              :    * the table has not yet been loaded in the local catalog cache.
              :    * Throws an AnalysisException if the table or the db does not exist in the Catalog.
              :    * This function does not register authorization requests and does not log access events
Please update this to reflect the new logic.


http://gerrit.cloudera.org:8080/#/c/4349/3/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java
File fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java:

PS3, Line 45: targetTable_
Just curious what the rationale behind this clean up. Is it because we use it only for the inserts? I don't know if we intend to use a bunch of referencedTables_ in the future for any other usecase in which case this change should again be undone. Alex, any idea?


http://gerrit.cloudera.org:8080/#/c/4349/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

Line 34: import java.util.concurrent.atomic.AtomicInteger;
Unused import now that we switched to Long?


-- 
To view, visit http://gerrit.cloudera.org:8080/4349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes