Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201610031608.u93G8Dvi026486@ip-10-146-233-104.ec2.internal>
Date: Mon, 3 Oct 2016 16:08:13 +0000
From: "Jim Apple (Code Review)" <gerrit@cloudera.org>
To: Jim Apple <jbapple@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>, David Knupp <dknupp@cloudera.com>,
        Taras Bobrovytsky <tbobrovytsky@cloudera.com>,
        Alex Behm <alex.behm@cloudera.com>, Michael Brown <mikeb@cloudera.com>
Reply-To: jbapple@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Don=27t_assume_that_AUX_exists_just_because_a_shell_variable_is_set=0A?=
In-Reply-To: <gerrit.1475167867000.Ieffb6d52c5f95d3257de8c47a039ccb0d45f0867@gerrit.cloudera.org>
References: <gerrit.1475167867000.Ieffb6d52c5f95d3257de8c47a039ccb0d45f0867@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Mon, 03 Oct 2016 16:08:19 -0000

Jim Apple has posted comments on this change.

Change subject: Don't assume that AUX exists just because a shell variable is set
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4563/2/tests/run-custom-cluster-tests.sh
File tests/run-custom-cluster-tests.sh:

PS2, Line 40: then
            :     impala-py.test custom_cluster/ authorization/ "${AUX_CUSTOM_DIR}" \
            :                    --junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml" \
            :                    --resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.log" "$@"
            : else
            :     impala-py.test custom_cluster/ authorization/ \
            :                    --junitxml="${RESULTS_DIR}/TEST-impala-custom-cluster.xml" \
            :                    --resultlog="${RESULTS_DIR}/TEST-impala-custom-cluster.log" "$@"
            : fi
> I don't like the code repetition, and it's not clear right away what the di
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieffb6d52c5f95d3257de8c47a039ccb0d45f0867
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes