impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock
Date Tue, 01 Nov 2016 00:00:38 GMT
Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4895

Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock
......................................................................

IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

This fixes a potential hang because the code took
QueryExecState::lock_ before SessionState::lock, which is
the wrong order. A hang has not yet been observed.

The code that was taking the session lock doesn't actually
need to be holding the QueryExecState lock_, so this is easy
to fix by moving the relevant code.

Testing: Running an exhaustive test job, and stress tests
manually.

Change-Id: I2aa36fce78525a80a6b880e1b668105006bc1425
---
M be/src/service/query-exec-state.cc
1 file changed, 12 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/4895/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2aa36fce78525a80a6b880e1b668105006bc1425
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message